Discussion:
[2.6 patch] drivers/pci/msi.c: fix a check after use
(too old to reply)
Adrian Bunk
2005-03-27 21:17:14 UTC
Permalink
This patch fixes a check after use found by the Coverity checker.

Signed-off-by: Adrian Bunk <***@stusta.de>

--- linux-2.6.12-rc1-mm1-full/drivers/pci/msi.c.old 2005-03-23 04:46:30.000000000 +0100
+++ linux-2.6.12-rc1-mm1-full/drivers/pci/msi.c 2005-03-23 04:47:03.000000000 +0100
@@ -703,12 +703,14 @@
**/
int pci_enable_msi(struct pci_dev* dev)
{
- int pos, temp = dev->irq, status = -EINVAL;
+ int pos, temp, status = -EINVAL;
u16 control;

if (!pci_msi_enable || !dev)
return status;

+ temp = dev->irq;
+
if ((status = msi_init()) < 0)
return status;


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to ***@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



-------------------------------------------------------------------------------
Achtung: diese Newsgruppe ist eine unidirektional gegatete Mailingliste.
Antworten nur per Mail an die im Reply-To-Header angegebene Adresse.
Fragen zum Gateway -> ***@inka.de.
-------------------------------------------------------------------------------
Greg KH
2005-03-28 23:27:31 UTC
Permalink
Post by Adrian Bunk
This patch fixes a check after use found by the Coverity checker.
Applied, thanks.

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to ***@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



-------------------------------------------------------------------------------
Achtung: diese Newsgruppe ist eine unidirektional gegatete Mailingliste.
Antworten nur per Mail an die im Reply-To-Header angegebene Adresse.
Fragen zum Gateway -> ***@inka.de.
-------------------------------------------------------------------------------
Loading...