[2.6 patch] drivers/usb/media/usbvideo.c: fix a check after use

[Adrian Bunk]

This patch fixes a check after use found by the Coverity checker.

Signed-off-by: Adrian Bunk <***@stusta.de>

--- linux-2.6.12-rc1-mm1-full/drivers/usb/media/usbvideo.c.old 2005-03-23 04:59:11.000000000 +0100
+++ linux-2.6.12-rc1-mm1-full/drivers/usb/media/usbvideo.c 2005-03-23 04:59:46.000000000 +0100
@@ -1814,12 +1814,12 @@
{
int i, j;

- if (uvd->debug > 1)
- info("%s($%p)", __FUNCTION__, uvd);
-
if ((uvd == NULL) || (!uvd->streaming) || (uvd->dev == NULL))
return;

+ if (uvd->debug > 1)
+ info("%s($%p)", __FUNCTION__, uvd);
+
/* Unschedule all of the iso td's */
for (i=0; i < USBVIDEO_NUMSBUF; i++) {
usb_kill_urb(uvd->sbuf[i].urb);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to ***@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



-------------------------------------------------------------------------------
Achtung: diese Newsgruppe ist eine unidirektional gegatete Mailingliste.
Antworten nur per Mail an die im Reply-To-Header angegebene Adresse.
Fragen zum Gateway -> ***@inka.de.
-------------------------------------------------------------------------------

[Jean Delvare]

Hi Adrian,

Post by Adrian Bunk
This patch fixes a check after use found by the Coverity checker.
--- linux-2.6.12-rc1-mm1-full/drivers/usb/media/usbvideo.c.old 2005-03-23 04:59:11.000000000 +0100
+++ linux-2.6.12-rc1-mm1-full/drivers/usb/media/usbvideo.c 2005-03-23 04:59:46.000000000 +0100
@@ -1814,12 +1814,12 @@
{
int i, j;
- if (uvd->debug > 1)
- info("%s($%p)", __FUNCTION__, uvd);
-
if ((uvd == NULL) || (!uvd->streaming) || (uvd->dev == NULL))
return;
+ if (uvd->debug > 1)
+ info("%s($%p)", __FUNCTION__, uvd);
+

Note that you slightly change the debug trace when doing this. For
example, the case where udv != NULL and !udv->streaming would display
the debug line before your patch, and no more after.

Now I don't know whether that change is a problem or not in this
particular case, as I am not the one who would debug this driver if
there were a problem with it, but this is something to pay attention to
in such cases.

Thanks,
--
Jean Delvare
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to ***@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



-------------------------------------------------------------------------------
Achtung: diese Newsgruppe ist eine unidirektional gegatete Mailingliste.
Antworten nur per Mail an die im Reply-To-Header angegebene Adresse.
Fragen zum Gateway -> ***@inka.de.
-------------------------------------------------------------------------------

[Greg KH]

Post by Adrian Bunk
This patch fixes a check after use found by the Coverity checker.

Applied, thanks.

greg k-h

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to ***@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



-------------------------------------------------------------------------------
Achtung: diese Newsgruppe ist eine unidirektional gegatete Mailingliste.
Antworten nur per Mail an die im Reply-To-Header angegebene Adresse.
Fragen zum Gateway -> ***@inka.de.
-------------------------------------------------------------------------------