Discussion:
[2.6 patch] drivers/pci/hotplug/cpqphp_core.c: fix a check after use
(too old to reply)
Adrian Bunk
2005-03-25 00:55:57 UTC
Permalink
This patch fixes a check after use found by the Coverity checker.

Signed-off-by: Adrian Bunk <***@stusta.de>

--- linux-2.6.12-rc1-mm1-full/drivers/pci/hotplug/cpqphp_core.c.old 2005-03-23 05:10:34.000000000 +0100
+++ linux-2.6.12-rc1-mm1-full/drivers/pci/hotplug/cpqphp_core.c 2005-03-23 05:10:55.000000000 +0100
@@ -577,11 +577,11 @@ cpqhp_set_attention_status(struct contro
{
u8 hp_slot;

- hp_slot = func->device - ctrl->slot_device_offset;
-
if (func == NULL)
return(1);

+ hp_slot = func->device - ctrl->slot_device_offset;
+
// Wait for exclusive access to hardware
down(&ctrl->crit_sect);


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to ***@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



-------------------------------------------------------------------------------
Achtung: diese Newsgruppe ist eine unidirektional gegatete Mailingliste.
Antworten nur per Mail an die im Reply-To-Header angegebene Adresse.
Fragen zum Gateway -> ***@inka.de.
-------------------------------------------------------------------------------
Greg KH
2005-03-28 23:14:52 UTC
Permalink
Post by Adrian Bunk
This patch fixes a check after use found by the Coverity checker.
Applied, thanks.

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to ***@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



-------------------------------------------------------------------------------
Achtung: diese Newsgruppe ist eine unidirektional gegatete Mailingliste.
Antworten nur per Mail an die im Reply-To-Header angegebene Adresse.
Fragen zum Gateway -> ***@inka.de.
-------------------------------------------------------------------------------
Loading...