Discussion:
[2.6 patch] drivers/usb/misc/usbtest.c: fix a NULL dereference
(too old to reply)
Adrian Bunk
2005-03-25 01:14:34 UTC
Permalink
This patch fixes a NULL dereference found by the Coverity checker.

Signed-off-by: Adrian Bunk <***@stusta.de>

--- linux-2.6.12-rc1-mm1-full/drivers/usb/misc/usbtest.c.old 2005-03-24 04:33:34.000000000 +0100
+++ linux-2.6.12-rc1-mm1-full/drivers/usb/misc/usbtest.c 2005-03-24 04:33:59.000000000 +0100
@@ -851,7 +851,7 @@
*/
urb = kmalloc (param->sglen * sizeof (struct urb *), SLAB_KERNEL);
if (!urb)
- goto cleanup;
+ return -ENOMEM;
memset (urb, 0, param->sglen * sizeof (struct urb *));
for (i = 0; i < param->sglen; i++) {
int pipe = usb_rcvctrlpipe (udev, 0);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to ***@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



-------------------------------------------------------------------------------
Achtung: diese Newsgruppe ist eine unidirektional gegatete Mailingliste.
Antworten nur per Mail an die im Reply-To-Header angegebene Adresse.
Fragen zum Gateway -> ***@inka.de.
-------------------------------------------------------------------------------
Greg KH
2005-03-28 20:53:51 UTC
Permalink
Post by Adrian Bunk
This patch fixes a NULL dereference found by the Coverity checker.
Applied, thanks.

greg k-h

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to ***@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



-------------------------------------------------------------------------------
Achtung: diese Newsgruppe ist eine unidirektional gegatete Mailingliste.
Antworten nur per Mail an die im Reply-To-Header angegebene Adresse.
Fragen zum Gateway -> ***@inka.de.
-------------------------------------------------------------------------------
Loading...